ref: Convert React and Vue Tracing to use active transaction #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
requested changes
Jul 14, 2020
Comment on lines
+389
to
+398
| export function getActiveTransaction<T extends Transaction>(hub: HubType): T | undefined { | ||
| if (hub && hub.getScope) { | ||
| const scope = hub.getScope() as Scope; | ||
| if (scope) { | ||
| return scope.getTransaction() as T | undefined; | ||
| } | ||
| } | ||
|
|
||
| return undefined; | ||
| } |
There was a problem hiding this comment.
Hmm, I don't like that we have this duplicated everywhere :/
There was a problem hiding this comment.
Isn't doing hub.getScope().getTransaction() the same?
There was a problem hiding this comment.
public getScope(): Scope | undefined
sentry-javascript/packages/hub/src/hub.ts
Line 140 in e8a37d2
There was a problem hiding this comment.
So it is more like hub?.getScope?.getTransaction()
There was a problem hiding this comment.
We can always refactor this if we figure out a better way to do this.
HazAT
approved these changes
Jul 14, 2020
AbhiPrasad
added a commit
that referenced
this pull request
Jul 14, 2020
* ref: Make React Profiler use active transaction * ref: Make Vue Tracing using active transaction
AbhiPrasad
added a commit
that referenced
this pull request
Jul 17, 2020
* feat: Create IdleTransaction class (#2720) * feat: Add BrowserTracing integration (#2723) * feat: Add span creators to @sentry/tracing package (#2736) * ref: Convert React and Vue Tracing to use active transaction (#2741) * build: generate tracing bundles * fix: Remove circular dependency between span and transaction * ref: Add side effects true to tracing * build: Only include @sentry/browser for bundle * fix: Make sure vue and react are backwards compatible with @sentry/apm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last PR before #2719 is ready :)
This one changes both React and Vue to add children to the current active transaction instead of pushing and popping activities.
This is a change in behaviour, as if the components no longer add/remove activities, the 0 activity point is reached more quickly by the
Tracingintegration, but I figured if we are looking to move past it, we should just do this.I updated the react tests and tested on Sentry and everything seems good.