fix(remix): Skip capturing ok responses as errors.
#5405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Jul 11, 2022
| function captureRemixServerException(err: Error, name: string): void { | ||
| // Skip capturing if the thrown error is a Response | ||
| // https://remix.run/docs/en/v1/api/conventions#throwing-responses-in-loaders | ||
| if (isResponse(err)) { |
There was a problem hiding this comment.
Could we still allow certain responses through? Like 500s? And then add the response data to the event also.
There was a problem hiding this comment.
Makes sense to me. Maybe something like >=400?
There was a problem hiding this comment.
Yeah that sounds reasonable.
3 tasks
onurtemizkan
changed the title
ok responses as errors.
AbhiPrasad
approved these changes
Jul 11, 2022
3 tasks
This was referenced Jul 18, 2022
lobsterkatie
pushed a commit
that referenced
this pull request
Jul 21, 2022
Fixes: #5425 Ref: #5429, #5405 As per review #5429 (comment), we need to define how and when we should capture a 4xx error. We will only capture thrown 5xx responses until then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5362
Remix supports throwing responses from
loaderandactionfunctions for its internalCatchBoundary.They are catched on the caller level, but as we wrap the callees, they are registered as exceptions in the SDK. Being http responses, they end up like
{size: 0}, which is not meaningful.This PR skips exception capturing for responses that are not
4xxor5xx.