Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix): Skip capturing ok responses as errors. #5405

Merged
merged 2 commits into from Jul 11, 2022
Merged

fix(remix): Skip capturing ok responses as errors. #5405

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
733e68b
fix(remix): Skip capturing response errors.
onurtemizkan Jul 11, 2022
845d0ee
Capture only erroneous responses.
onurtemizkan Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/remix/src/utils/instrumentServer.ts
View file
Open in desktop
Expand Up @@ -69,7 +69,29 @@ interface DataFunction {
(args: DataFunctionArgs): Promise<Response> | Response | Promise<AppData> | AppData;
}


// Taken from Remix Implementation
// https://github.com/remix-run/remix/blob/7688da5c75190a2e29496c78721456d6e12e3abe/packages/remix-server-runtime/responses.ts#L54-L62
// eslint-disable-next-line @typescript-eslint/no-explicit-any
function isResponse(value: any): value is Response {
return (
value != null &&
/* eslint-disable @typescript-eslint/no-unsafe-member-access */
typeof value.status === 'number' &&
typeof value.statusText === 'string' &&
typeof value.headers === 'object' &&
typeof value.body !== 'undefined'
/* eslint-enable @typescript-eslint/no-unsafe-member-access */
);
}

function captureRemixServerException(err: Error, name: string): void {
// Skip capturing if the thrown error is a Response
// https://remix.run/docs/en/v1/api/conventions#throwing-responses-in-loaders
if (isResponse(err)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we still allow certain responses through? Like 500s? And then add the response data to the event also.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Maybe something like >=400?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that sounds reasonable.

return;
}

captureException(err, scope => {
scope.addEventProcessor(event => {
addExceptionMechanism(event, {
Expand Down