Sync develop -> master
#11196
Closed
Sync develop -> master
#11196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rimental` packages (#11116)
Size seems to be much increased, let's figure this out in follow ups. Also there is some issue with it reading next.js sizes, also something we can look at in follow ups... I disabled these size checks for now. The action is now inlined as a package in the monorepo, as our fork has been archived and the upstream package is not really maintained and works pretty different from what we need. Now we at least have full control over this.
ref #11062 --------- Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
[Gitflow] Merge master into develop
Noticed this is failing e.g. https://github.com/getsentry/sentry-javascript/actions/runs/8294578489/job/22700116991, it was an incorrect check: if there is no comparison branch, we don't need a PR.
Apparently, webpack looks at `sideEffects` in the generated package.json, and based on this does not tree shake correctly 😬 I also bumped webpack (one of the things I tried while debugging this...). This now puts the original `sideEffects` value from the original `package.json` and puts it into the esm package.json.
This PR switches the underlying Node SDK from `@sentry/node-experimental` (aka the "legacy" v7 Node SDK) to the new OpenTelemetry-based `@sentry/node` package.
- Removes `makeMain` impl and exports from node (and downstream SDKs) - Removes custom `getCurrentHub/getClient` impl in favour of core - Removes `callExtensionMethod` as its not called from anywhere - Fixes all the tests that relied on `getClient` never returning undefined - Removes `_callExtensionMethod` from core as it's not used
…11128) I think we missed this from removing the other class-based exports.
Removes `getIntegrationById` and `getIntegration` methods on client. Doesn't touch anything on the hub because we want to shim those methods.
closes #11136 closes #11062 closes #11137 closes #11138 closes #11139 In #11134 we changed the playwright tests use a larger GH runner. This should hopefully fix the flaky replay playwright tests. Validating that here. Note that `Detect flaky tests / Check tests for flakiness` runs on the smaller workers, so it'll experience the same issues we had before.
…11135) - Moves Sentry deps to `dependencies` rather than `devDependencies` - Updated `package.json` exports - Updated the rollup config to mirror our other modules with the addition of the commonJs plugin - I couldn't use `createRequire` myself because Jest can't handle `import.meta` so instead I used `@rollup/plugin-esm-shim` which shims both `require` and `__dirname` in `cpu_profiler.ts` in the ESM output!
`@sentry/types` does not align with `@sentry/core`, and it causes build errors when `exactOptionalPropertyTypes` is `true`. This patch fixes the TypeScript error by explicitly adding `undefined` to the `sampled` flag of `Transaction`.
… in favor of `instrumentation.ts` (#11059)
Ref: #11107 Removes `--detectOpenHandles` from Jest configurations of Remix and Next.JS which apparently causes segfault. Re-enables Remix Node 16 and Node 18 integration tests on CI
In #8927 we deprecated and removed the `wrap` method. This PR removes the deprecated export from v8.
Removes exports for `ModuleMetadata` and `RequestData`
Closes #11159 This PR also modifies `getEnvelopeEndpointWithUrlEncodedAuth` which had a suggested simplification for v8. I ignored the suggestion because `{ tunnel, _metadata }` feels like a very "internal" API. Sure, this is convenient because it lets you pass the client options directly but it doesn't sit right as a user facing API.
ref #9832 Deletes deprecated imports from utils package in preparation to move it to core/related. Also important because deleting `addOrUpdateIntegration` and it's associated tests means that we remove more usages of class based integrations.
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Closes #11118 This PR exports what used to be called `initOtel` so that the `NodeClient` can be used without calling `init`. If OpenTelemetry is only required for performance feature, we should also only enable it if the sample rate is above zero to save memory.
merge `release/8.0.0-alpha.4`
Fixes some cropping jank: 1. Cropping is smoother: previously the event listeners weren't working when the mouse was on the cropping buttons, which was causing the jankiness 2. Changes the cursor when on the cropping buttons 3. Increased the minimum size required for cropping so it's easier to resize https://github.com/getsentry/sentry-javascript/assets/55311782/71b7401e-c9f2-44c2-9f92-64c1c80d24ef Fixes getsentry/sentry#67056
Reduce force layout/reflow by reducing calls mentioned [here](https://gist.github.com/paulirish/5d52fb081b3570c81e3a)
We use [getDisplayMedia](https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getDisplayMedia) to take screenshots, which only works in secure contexts, so disable screenshot when not a secure context.
|
|
size-limit report 📦
|
AbhiPrasad
approved these changes
Mar 19, 2024
Move v4, v5, and v6 changelog entries into their own file. This should help speed up rendering of main changelog. Also add relevant v7 changelog items to changelog.
In order to proceed with removing `Sentry.Integrations.X` as per #8844, there's still some places to clean up. This does conflict with #11016, but not sure when that merges in, so opening this in the meantime to unblock the integrations cleanup work. if we think the OTEL nextjs work will merge in sooner then the next 1-2 days, I'm happy to leave this alone for now!
We received reports about this error ``` TypeError: Cannot redefine property: googletag ``` being thrown and reported to Sentry. It's a noisy error where we strongly suspect that browser extensions interfere with our users' apps. In an effort to quickly reduce noise, this patch adds the error message to our SDK `inboundFilters` integration.
|
This is too cumbersome to merge (i.e. get CI green before the next commit happens). I'm gonna close the PR. we should be good to just merge with the next alpha release which is also fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday, I merged the
release/8.0.0-alpha.4branch intodevelop. Turns out it should have been merged intomasterinstead after which we'd mergemasterintodevelop.So to fix the "stale" master branch, this PR simply merges the current
developbranch intomasterwhich will bump the packages onmastercorrectly. This also means thatmastercontains commits that haven't been released yet but that's fine. This should be cleaned up nicely once we cut the next release.