fix(browser): Wait until response has finished streaming before calling fetch handlers #11558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng fetch handlers
size-limit report 📦
|
lforst
commented
Apr 12, 2024
Comment on lines
+100
to
+104
| return new Promise(resolve => { | ||
| setTimeout(() => { | ||
| resolve(response); | ||
| }, 0); | ||
| }); |
There was a problem hiding this comment.
God I hate that we need this not to fail breadcrumb tests on webkit
lforst
force-pushed
the
lforst-fix-fetch-spans-v8
branch
from
298f067
to
5d4d977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.