feat(replay): Add option to pass in custom record fn #11702
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
force-pushed
the
feat-replay-allow-external-record-fn
branch
2 times, most recently
from
9699435
to
5708be8
Compare
size-limit report 📦
|
Bringing back #8647 but it would be nice to test new versions of rrweb without having to bundle it with our replay SDK.
billyvg
force-pushed
the
feat-replay-allow-external-record-fn
branch
from
5708be8
to
0376fe3
Compare
billyvg
commented
Apr 23, 2024
| @@ -1,5 +1,4 @@ | |||
| import { record } from '@sentry-internal/rrweb'; | |||
| import type { serializedElementNodeWithId, serializedNodeWithId } from '@sentry-internal/rrweb-snapshot'; | |||
There was a problem hiding this comment.
Hmm, the ts3.8 tests are failing because this snapshot package uses Lowercase (amongst others) that were introduced after 3.8 (Lowercase was added in 4.1), but we've always been pulling in types from snapshot, so not sure why they are now failing. The only difference is we are importing Mirror type.
any ideas @AbhiPrasad?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing back #8647 but it would be nice to test new versions of rrweb without having to bundle it with our replay SDK.