Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(browser): inAppIntegration which uses debugId filenames to determine in_app on stack frames #11711

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Apr 22, 2024

Currently in the browser, all stack frames are marked with in_app: true which makes it difficult to determine if the error originated from user code or elsewhere.

If we have debugIds we can assume that these filenames are the users app code and everything else is not.

This PR adds the inAppIntegration that uses the filenames associated with debugIds to determine in_app. It adds a getFilenameDebugIdMap function which replaces identical code in 3 other places.

Copy link
Contributor

github-actions bot commented Apr 22, 2024

size-limit report 📦

Path Size
@sentry/browser 21.66 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) 31.4 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) 66.72 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.13 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.56 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) 82.95 KB (-0.02% 🔽)
@sentry/browser (incl. Feedback) 37.77 KB (-0.03% 🔽)
@sentry/browser (incl. sendFeedback) 26.45 KB (-0.02% 🔽)
@sentry/browser (incl. FeedbackAsync) 30.92 KB (-0.02% 🔽)
@sentry/react 24.35 KB (-0.03% 🔽)
@sentry/react (incl. Tracing) 34.32 KB (+0.02% 🔺)
@sentry/vue 25.2 KB (+0.02% 🔺)
@sentry/vue (incl. Tracing) 33.12 KB (+0.02% 🔺)
@sentry/svelte 21.79 KB (0%)
CDN Bundle 23.98 KB (+0.04% 🔺)
CDN Bundle (incl. Tracing) 32.67 KB (+0.06% 🔺)
CDN Bundle (incl. Tracing, Replay) 66.32 KB (+0.01% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 82.1 KB (+0.02% 🔺)
CDN Bundle - uncompressed 70.65 KB (+0.04% 🔺)
CDN Bundle (incl. Tracing) - uncompressed 97.29 KB (+0.03% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 206.96 KB (+0.02% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 253.24 KB (+0.01% 🔺)
@sentry/nextjs (client) 33.64 KB (0%)
@sentry/sveltekit (client) 31.9 KB (-0.01% 🔽)
@sentry/node 157.29 KB (-0.01% 🔽)

@timfish timfish changed the title feat(browser): If we have debugIds, use filenames to populate in_app on stack frames feat(browser): inAppIntegration which uses debugId filenames to determine in_app on stack frames Apr 22, 2024
@timfish timfish requested a review from lforst April 22, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant