fix(angular): Run tracing calls outside of Angular #11748
Conversation
There was a problem hiding this comment.
Hey @arturovt thanks for opening all these Angular PRs, great to see the Angular SDK getting some love from the community :D
This change sounds reasonable to me - let me know when it is ready for a review!
(heads-up: CI seems to have detected a formatting issue. I suggest running yarn fix:biome to resolve it)
|
Yeah, I was waiting for other PR to be merged. (could never thought it's called |
This commit updates all tracing functionality to run outside the Angular zone. Before this change, it hindered server-side rendering and hydration, causing instability in the app. The app achieves stability when there are no micro/macro tasks running. As a result, the HTML can now be serialized and sent to the client.
arturovt
force-pushed
the
fix/tracing-stable
branch
from
d9a67b4
to
d1ba98f
Compare
yeah, it's because we use biome instead of prettier (for now; we'll probably revert in a couple of weeks) 😅 |
|
heads-up: I re-created your PR (#11794) just to run our e2e test for Angular. Unfortunately our e2e tests don't run on external contributor PRs. Once the test passes, I'll merge your PR. |
Lms24
changed the title
This commit updates all tracing functionality to run outside the Angular zone. Before this change, it hindered server-side rendering and hydration, causing instability in the app. The app achieves stability when there are no micro/macro tasks running. As a result, the HTML can now be serialized and sent to the client.