Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(feedback): Rename and add missing Label constants to feedback #11953

Merged
merged 3 commits into from
May 8, 2024

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented May 8, 2024

Adding some missing labels that users will need access to if they want to do translations. Also took the chance to rename a few to better align with the other labels, and with their use.

@ryan953 ryan953 requested a review from a team as a code owner May 8, 2024 15:21
@ryan953 ryan953 force-pushed the ryan953/ref-feedback-constants branch from 8ec9c8c to cb4136c Compare May 8, 2024 15:27
@ryan953 ryan953 force-pushed the ryan953/ref-feedback-constants branch from 497e1a5 to d5a76f7 Compare May 8, 2024 16:21
Copy link
Contributor

github-actions bot commented May 8, 2024

size-limit report 📦

Path Size
@sentry/browser 21.65 KB (0%)
@sentry/browser (incl. Tracing) 32.68 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.02 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.42 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.06 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.22 KB (+0.09% 🔺)
@sentry/browser (incl. Feedback) 37.74 KB (+0.21% 🔺)
@sentry/browser (incl. sendFeedback) 26.21 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.9 KB (+0.21% 🔺)
@sentry/react 24.33 KB (0%)
@sentry/react (incl. Tracing) 35.64 KB (0%)
@sentry/vue 25.48 KB (0%)
@sentry/vue (incl. Tracing) 34.47 KB (0%)
@sentry/svelte 21.78 KB (0%)
CDN Bundle 24.13 KB (0%)
CDN Bundle (incl. Tracing) 34.05 KB (0%)
CDN Bundle (incl. Tracing, Replay) 67.72 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 73 KB (+0.1% 🔺)
CDN Bundle - uncompressed 70.99 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 101 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.61 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 224.1 KB (+0.1% 🔺)
@sentry/nextjs (client) 34.87 KB (0%)
@sentry/sveltekit (client) 33.24 KB (0%)
@sentry/node 147.35 KB (-0.01% 🔽)

Copy link
Member

@c298lee c298lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@ryan953 ryan953 enabled auto-merge (squash) May 8, 2024 17:26
@ryan953 ryan953 merged commit 3aca0f8 into develop May 8, 2024
98 checks passed
@ryan953 ryan953 deleted the ryan953/ref-feedback-constants branch May 8, 2024 17:27
andreiborza pushed a commit that referenced this pull request May 16, 2024
…1953)

Adding some missing labels that users will need access to if they want
to do translations. Also took the chance to rename a few to better align
with the other labels, and with their use.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants