feat: LinkedErrors integration for Node #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
force-pushed
the
linked-errors
branch
from
d9797ed
to
b75c254
Compare
kamilogorek
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1511 +/- ##
==========================================
+ Coverage 73.08% 73.65% +0.57%
==========================================
Files 44 45 +1
Lines 1330 1359 +29
Branches 250 256 +6
==========================================
+ Hits 972 1001 +29
Misses 350 350
Partials 8 8
Continue to review full report at Codecov.
|
HazAT
requested changes
Sep 6, 2018
| @@ -0,0 +1,71 @@ | |||
| import { getCurrentHub } from '@sentry/hub'; | |||
There was a problem hiding this comment.
we always need import { getCurrentHub } from '../hub'; in node, since the current hub could live on a domain.
| import { Integration, SentryEvent, SentryEventHint, SentryException } from '@sentry/types'; | ||
| import { getExceptionFromError } from '../parsers'; | ||
|
|
||
| /** JSDoc */ |
kamilogorek
force-pushed
the
linked-errors
branch
from
b75c254
to
b3188f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion on #1401 (comment)
It has to be ported to the browser though, as extracting stackframe is slightly different there and we cannot reuse exactly the same code.