Remove use of the words blacklist and whitelist #2641
Conversation
|
@HazAT Yeah that makes sense, what do you think of aliasing those terms to expose them publicly in a different manner so both terms are valid for a period of time (encouraging users to change over)? |
|
@AJDoubleW Yeah that's pretty much what I meant. |
| /** | ||
| * A pattern for error URLs which should not be sent to Sentry. | ||
| * To whitelist certain errors instead, use {@link Options.whitelistUrls}. | ||
| * To include certain errors instead, use {@link Options.includedUrls}. | ||
| * By default, all errors will be sent. | ||
| */ | ||
| excludedUrls?: Array<string | RegExp>; | ||
| blacklistUrls?: Array<string | RegExp>; |
There was a problem hiding this comment.
Can we add a docblock here to both old values:
/**
* @deprecated Consider removing in major bump
* {@see excludedUrls}
**/
|
I'm in favor of the direction and spirit of this change. But before we merge this, we (Sentry) need to discuss the exact terminology we want to replace it with, and make the change wholesale inside Sentry (e.g. across all SDKs and in the product). For example, |
|
Superseded by #2671 |
Fixes #2640