chore(react): cleanup outstanding TODOs on @sentry/react #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
force-pushed
the
abhi/react/cleanup
branch
from
3fca5b0
to
baf1631
Compare
HazAT
reviewed
Jun 10, 2020
| @@ -1,4 +1,27 @@ | |||
| import { addGlobalEventProcessor, SDK_VERSION } from '@sentry/browser'; | |||
There was a problem hiding this comment.
That we import SDK_VERSION here is not optimal.
The versions should never go out of sync but maybe it's better to also create a version.ts file like in the other packages and put it there. (Name & Version).
HazAT
approved these changes
Jun 10, 2020
AbhiPrasad
force-pushed
the
abhi/react/cleanup
branch
from
23a96b5
to
755d4d8
Compare
Use an event processor to correctly set SDK and package name
AbhiPrasad
force-pushed
the
abhi/react/cleanup
branch
from
755d4d8
to
1db3474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #2659
Motivation
As I'm getting ready to test with getsentry, I went ahead and made a PR to cleanup and review all the react integration components.
Didn't think these small changes required a CHANGELOG entry, but please let me know if they do.
The commits
feat(react): Add Event Processor for React0e2bf38addGlobalEventProcessorthat changes the sdk name tosentry.javascript.reactchore(react): Update comments and test for Profileraeb266ffix(react): Correctly give eventID to dialog3fca5b0sentry.captureExceptionis given to the report dialogfix(react): Prevent state updates from creating activities23a96b5useStateas otherwise we create new transactions every render. Previously if we updated a child component (like clicking a button to increment a counter), we get this:Future
Test with getsentry. Also need to add a proper README, but will do that after getsentry testing.