New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Rewrite React Profiler #2677
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e997d54
fix(react): check for event processor
AbhiPrasad c255137
ref: use global tracing integration
AbhiPrasad 8bc23ce
ref: extract into popActivity
AbhiPrasad dc0d9ba
ref: add disabled and extra activities:
AbhiPrasad 4eddf1a
ref: Add visibleActivity:
AbhiPrasad 75913f0
ref: Rework rest of integration
AbhiPrasad 371a247
ref: create children from span
AbhiPrasad 33337c2
ref: change update logic
AbhiPrasad 995da2d
delete some code
AbhiPrasad be57d6f
generate spans properly
AbhiPrasad fc8b166
chore: update comments
AbhiPrasad ef2f3d7
test: Revamp for rewrite
AbhiPrasad 3c5a8d6
ref: Remove parentSpanId option
AbhiPrasad cb2ce41
Rework render span
AbhiPrasad b43352e
CHANGELOG
AbhiPrasad fe90612
ref: Change getActivitySpan to not check hub
AbhiPrasad 4e7eed5
remove params
AbhiPrasad 2743af0
cleanup
AbhiPrasad 0a32bf5
Merge branch 'master' into abhi/ref/react-profiler
AbhiPrasad File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there cases where we don't have
addGlobalEventProcessor
? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a user doesn't mock it out in tests, don't want to create unnecessary friction.