Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import of hoist-non-react-statics #2755

Merged
merged 3 commits into from Jul 21, 2020
Merged

Fix import of hoist-non-react-statics #2755

merged 3 commits into from Jul 21, 2020

Commits on Jul 20, 2020

  1. Fix import of hoist-non-react-statics 

    The module uses a default export, so the star import is technically incorrect form: https://github.com/mridgway/hoist-non-react-statics/blob/f3de655212b47f20b9c6a27e89a60d23f358925a/src/index.js#L91

As a side effect, this causes build errors with Rollup: `(!) Cannot call a namespace ('hoistNonReactStatic')`
    @timdorr
    timdorr committed Jul 20, 2020
    Copy the full SHA
    f41b6ab View commit details
    Browse the repository at this point in the history

  2. Add esModuleInterop for interop with CJS modules 

    hoist-non-react-statics causes this issue, as it's built as a CommonJS module. This lets the default import function correctly on the transpiled build output in the npm module.
    @timdorr
    timdorr committed Jul 20, 2020
    Copy the full SHA
    2a81485 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Merge branch 'master' into import-fix

    @kamilogorek
    kamilogorek committed Jul 21, 2020
    Copy the full SHA
    70f4625 View commit details
    Browse the repository at this point in the history