Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@sentry/gatsby): Specify gatsby peer dep #3385

Merged
merged 1 commit into from Apr 12, 2021
Merged

fix(@sentry/gatsby): Specify gatsby peer dep #3385

merged 1 commit into from Apr 12, 2021

Conversation

LekoArts
Copy link
Contributor

Hello, Gatsby maintainer here 馃憢

While looking at the Gatsby plugin I noticed that the peerDependency on gatsby is set incorrectly. We're in the process of providing more helpful information on the /plugins page of our website and for that we need plugins to set their peerDependencies correctly/more specific.

At the moment you say that any version (v3, v4, v5, v6, etc.) will work with this even when in between we'd introduce breaking changes.

Making it more explicit is the safer choice (in the future you'll be able to mark breaking changes with explicit version ranges) and will allow us to display the plugin as compatible to versions X, Y, Z.

Using Git blame I found this comment: #2652 (comment)
The APIs the plugin uses are safe to use on v2 and v3 of Gatsby :)

Thanks!

@kamilogorek kamilogorek merged commit 5e8e996 into getsentry:master Apr 12, 2021
@kamilogorek
Copy link
Contributor

Makes perfect sense, thanks!

@LekoArts LekoArts deleted the patch-1 branch April 12, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants