Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ember): Restore ember package contents #5318

Merged
merged 1 commit into from Jun 27, 2022
Merged

fix(ember): Restore ember package contents #5318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Expand Up @@ -12,7 +12,8 @@ on:
required: false

env:
DEFAULT_NODE_VERSION: '16'
# We pin the exact version to enforce reproducable builds with node + npm.
DEFAULT_NODE_VERSION: '16.15.1'

HEAD_COMMIT: ${{ github.event.inputs.commit || github.sha }}

Expand Down Expand Up @@ -58,15 +59,15 @@ jobs:
echo "COMMIT_SHA=$COMMIT_SHA" >> $GITHUB_ENV
echo "COMMIT_MESSAGE=$(git log -n 1 --pretty=format:%s $COMMIT_SHA)" >> $GITHUB_ENV
outputs:
commit_label: "${{ env.COMMIT_SHA }}: ${{ env.COMMIT_MESSAGE }}"
commit_label: '${{ env.COMMIT_SHA }}: ${{ env.COMMIT_MESSAGE }}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No action required: I guess those are some automatic Prettier (or similar) changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I'll leave it (I'm sorry for the messed up git history).


job_install_deps:
name: Install Dependencies
needs: job_get_metadata
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- name: "Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})"
- name: 'Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})'
uses: actions/checkout@v2
with:
ref: ${{ env.HEAD_COMMIT }}
Expand All @@ -93,7 +94,7 @@ jobs:

job_build:
name: Build
needs: [ job_get_metadata, job_install_deps ]
needs: [job_get_metadata, job_install_deps]
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
Expand Down
4 changes: 4 additions & 0 deletions packages/ember/.npmignore
View file
Open in desktop
@@ -1,3 +1,6 @@
# Disable rules of .npmignore in workspace root for this package
!*

# compiled output
/dist/
/tmp/
Expand All @@ -24,6 +27,7 @@
/testem.js
/tests/
/yarn.lock
/.npmignore
.gitkeep

# ember-try
Expand Down