Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): Add PolymorphicRequest type #5744

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

lobsterkatie
Copy link
Member

This is a change which comes out of a code review of #5703, moving the CrossPlatformType from @sentry/utils to @sentry/types and renaming it PolymorphicRequest (to match the existing PolymorphicEvent). Because it affects a number of files, I decided to pull it into its own PR, just to not confuse things in that one.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.53 KB (+0.02% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.31 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.12 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 53.23 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.91 KB (0%)
@sentry/browser - Webpack (minified) 64.61 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.93 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.97 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.1 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.48 KB (+0.01% 🔺)

@lobsterkatie lobsterkatie force-pushed the kmclb-add-polymorphicrequest-type branch from d86cd7d to 6b45a4d Compare September 15, 2022 05:35
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

Copy link
Contributor

@vladanpaunovic vladanpaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this more explicit.

Please fix tests and linting. Then it's good to go.

@lobsterkatie
Copy link
Member Author

Please fix tests and linting.

Yeah, of course. This is what I get for pushing right before I go to bed and not waiting for CI... I don't get a chance to fix all my dumb mistakes, LOL.

@lobsterkatie lobsterkatie force-pushed the kmclb-add-polymorphicrequest-type branch from 6b45a4d to 270809e Compare September 15, 2022 15:57
@lobsterkatie lobsterkatie merged commit 903addf into master Sep 15, 2022
@lobsterkatie lobsterkatie deleted the kmclb-add-polymorphicrequest-type branch September 15, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants