feat(node): Node client extends ServerRuntimeClient rather than BaseClient
#8933
Conversation
|
Still trying to work out how this could be impacting a couple of |
…rverRuntimeClient
|
Any idea why the span processor doesn't work? 🤔 |
I was going to ask you 😂 |
|
Ah wonderful. Thanks for working this out! |
…m/timfish/sentry-javascript into feat/node-use-ServerRuntimeClient
…m/timfish/sentry-javascript into feat/node-use-ServerRuntimeClient
|
The new test failures were all down to These will become sync in v8 but for now they are using |
| @@ -46,7 +49,7 @@ export class ServerRuntimeClient< | |||
| * @inheritDoc | |||
| */ | |||
| public eventFromException(exception: unknown, hint?: EventHint): PromiseLike<Event> { | |||
| return Promise.resolve(eventFromUnknownInput(getCurrentHub, this._options.stackParser, exception, hint)); | |||
| return resolvedSyncPromise(eventFromUnknownInput(getCurrentHub, this._options.stackParser, exception, hint)); | |||
There was a problem hiding this comment.
This cost me hours! 😭
There was a problem hiding this comment.
Sorry you had to go through this! 😭
Thanks for figuring it out!!
…seClient` (#8933) Since common server bahaviour has now moved to `ServerRuntimeClient`, the Node client can now extend that rather than the base client. This PR also moves the request session flusher to `ServerRuntimeClient` which leaves the Node client empty apart from a constructor wrapper to preserve backwards compatibilty.
Ref: #8693
Since common server bahaviour has now moved to
ServerRuntimeClient, the Node client can now extend that rather than the base client.This PR also moves the request session flusher to
ServerRuntimeClientwhich leaves the Node client empty apart from a constructor wrapper to preserve backwards compatibilty.