Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding bindings to SQL spans in tracing #804

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Adding bindings to SQL spans in tracing #804

merged 4 commits into from
Nov 22, 2023

Conversation

summerKK
Copy link
Contributor

I submitted a PR for #801. 馃槈

cleptric
cleptric reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, left some super nitpicky comments 馃槃

src/Sentry/Laravel/Tracing/EventHandler.php Outdated Show resolved Hide resolved
src/Sentry/Laravel/Tracing/EventHandler.php Outdated Show resolved Hide resolved
src/Sentry/Laravel/Tracing/EventHandler.php Outdated Show resolved Hide resolved
stayallive
stayallive approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've cleaned up the tests a bit since we already had some stuff in place for testing queries. But otherwise looking good, thanks!

Let's see if we need to adjust the db.sql.bindings key but otherwise 馃殺

@cleptric cleptric merged commit 14760f7 into getsentry:master Nov 22, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleptric cleptric cleptric left review comments

@AbhiPrasad AbhiPrasad AbhiPrasad left review comments

@stayallive stayallive stayallive approved these changes

Assignees
No one assigned
Labels
Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@summerKK @stayallive @cleptric @AbhiPrasad