Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue tracing bugfixes #820

Merged
merged 10 commits into from
Jan 16, 2024
Merged

Queue tracing bugfixes #820

merged 10 commits into from
Jan 16, 2024

Conversation

stayallive
Copy link
Collaborator

@stayallive stayallive commented Dec 17, 2023

Fixes the following:

  • Moves the queue tests to a more logical place, and adds tests for the queue job tracing feature flag
  • Fixes bug where feature tests are incorrectly memoized in the feature class (this goes for all feature classes, not just the queue although it was only noticeable there since it had multiple options of the same category)
  • Fixes trace context being lost for queue.process transactions because the context was overwritten by the default context because there was no active span in the scope which is required for the correct context being added to the transaction event (fixed in PHP SDK instead)

Especially the last point is important, this fixes data to get lost for queue job transactions, the before:

image

and after the change:

image

this also fixes the missing operation name in the performance dashboard (top one old, bottom one new) and missing data on the transaction itself (the queue job name and attempts and such):

image

@stayallive stayallive self-assigned this Dec 17, 2023
@stayallive stayallive marked this pull request as ready for review December 17, 2023 17:03
@stayallive stayallive changed the title Queue tracing improvements Queue tracing bugfixes Dec 17, 2023
@stayallive
Copy link
Collaborator Author

getsentry/sentry-php#1668 fixes part of this PR, back to draft to validate and update.

@stayallive stayallive marked this pull request as draft December 21, 2023 14:45
@stayallive stayallive marked this pull request as ready for review December 21, 2023 16:51
@stayallive stayallive merged commit 9421a96 into master Jan 16, 2024
22 checks passed
@stayallive stayallive deleted the queue-improvements branch January 16, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants