-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queue tracing bugfixes #820
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getsentry/sentry-php#1668 fixes part of this PR, back to draft to validate and update. |
This reverts commit ff3c28d.
That flag was removed in phpunit 10 and not really needed on older versions.
cleptric
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following:
Fixes(fixed in PHP SDK instead)trace
context being lost forqueue.process
transactions because the context was overwritten by the default context because there was no active span in the scope which is required for the correct context being added to the transaction eventEspecially the last point is important, this fixes data to get lost for queue job transactions, the before:
and after the change:
this also fixes the missing operation name in the performance dashboard (top one old, bottom one new) and missing data on the transaction itself (the queue job name and attempts and such):