Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix criteria for valid user data #1108

Merged
merged 7 commits into from Oct 12, 2020
Merged

Fix criteria for valid user data #1108

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bc0f644
fix criteria for valid user data
Oct 2, 2020
930ee94
CR
stayallive Oct 9, 2020
ee60667
Add changelog entry
stayallive Oct 9, 2020
49ca6ea
Merge branch 'master' into pullrequests/ahaurat/bugfix-1107-allow-use…
stayallive Oct 9, 2020
81174ac
CS
stayallive Oct 9, 2020
a43aee2
CR
stayallive Oct 12, 2020
eb874e8
Add missing constructor tests
stayallive Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/UserDataBag.php
View file
Open in desktop
Expand Up @@ -71,8 +71,8 @@ public static function createFromUserIpAddress(string $ipAddress): self
*/
public static function createFromArray(array $data): self
{
if (!isset($data['id']) && !isset($data['ip_address'])) {
throw new \InvalidArgumentException('Either the "id" or the "ip_address" field must be set.');
if (!isset($data['id']) && !isset($data['username']) && !isset($data['email']) && !isset($data['ip_address'])) {
throw new \InvalidArgumentException('One of the following fields must be set: "id", "username", "email" or "ip_address".');
}

$instance = new self();
Expand Down