Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debugging experience #1705

Merged
merged 14 commits into from
Mar 14, 2024
Merged

Improve debugging experience #1705

merged 14 commits into from
Mar 14, 2024

Conversation

stayallive
Copy link
Collaborator

@stayallive stayallive commented Feb 20, 2024

Improves the following:

  • Coalesce installed integration messages to a single line
  • Successful transmission of all event types
  • More detailed send logs (event type, error level)
  • Transactions started with tracing disabled
  • Transactions are not sampled/not started
  • Profiler starts/ends
  • Message if a profile was started without the excimer extension being present
  • The profile was too short (less than 20ms/two samples)
  • The profile was too long (more than 30s)
  • zend.exception_ignore_args is On
Example from go
[Sentry] 2024/02/20 11:21:56 Skipping transaction profiling: ProfilesSampleRate is: 0.000000
[Sentry] 2024/02/20 11:21:56 Sending info event [84846f6937534d0c9db663f363cb5a7b] to o123.ingest.sentry.io project: 123
[Sentry] 2024/02/20 11:21:56 Sending transaction [02b7142ef1e4410f821bc5f9d8d253af] to o123.ingest.sentry.io project: 123
Example output from changes in this PR

It is hard to show them all but to give you an idea:

sentry/sentry: [debug] The "Sentry\Integration\RequestIntegration, Sentry\Integration\TransactionIntegration, Sentry\Integration\FrameContextifierIntegration, Sentry\Integration\EnvironmentIntegration, Sentry\Integration\ModulesIntegration" integration(s) have been installed.
sentry/sentry: [info] Skipping fatal event [852155aa253643e0baf81e707f78be59], because no DSN is set.
sentry/sentry: [info] Skipping event [fd2b238ae2cb492c99e17f3415e882a5], because no DSN is set.
sentry/sentry: [info] Transaction [1180ef33b78e48ec82ee27e79cc3bb9a] was started and sampled, decided by config:traces_sample_rate.
sentry/sentry: [info] Transaction [1180ef33b78e48ec82ee27e79cc3bb9a] is not profiling because it was not sampled.
sentry/sentry: [info] Skipping transaction [d136c35956104e69a827bd23af1e67f8], because no DSN is set.

Previously (master):

sentry/sentry: [debug] The "Sentry\Integration\RequestIntegration" integration has been installed.
sentry/sentry: [debug] The "Sentry\Integration\TransactionIntegration" integration has been installed.
sentry/sentry: [debug] The "Sentry\Integration\FrameContextifierIntegration" integration has been installed.
sentry/sentry: [debug] The "Sentry\Integration\EnvironmentIntegration" integration has been installed.
sentry/sentry: [debug] The "Sentry\Integration\ModulesIntegration" integration has been installed.

Fixes #1704.

@stayallive stayallive marked this pull request as ready for review March 5, 2024 14:05
src/Profiling/Profiler.php Outdated Show resolved Hide resolved
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Game changer!

@stayallive stayallive merged commit 76a2184 into master Mar 14, 2024
31 checks passed
@stayallive stayallive deleted the improve-logging branch March 14, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve debugging experience
2 participants