-
Notifications
You must be signed in to change notification settings - Fork 464
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ref: Store tracked spans on start not finish (#738)
This matches the JS implementation. Without it, we cannot use the span recorder of a span to find its parent transaction. Note about test changes Instrumented subprocess methods are called in this order: __init__, communicate, wait. Because we now store the spans on start, that's the order we expect the spans to be in. The previous order was based on finish time. Grouping the assertion of "op" values together produces better output on failure, because one can easily detect what all the "op" values are, instead of being left with only the first one that is different. Similar to subprocess changes, the order of expected middleware spans in Django is now sorted by start time.
- Loading branch information
1 parent
e9389b0
commit b539ecb
Showing
3 changed files
with
32 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters