Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transcations) Transaction source #1489

Closed
18 tasks done
smeubank opened this issue Jul 11, 2022 · 0 comments · Fixed by #1490
Closed
18 tasks done

feat(transcations) Transaction source #1489

smeubank opened this issue Jul 11, 2022 · 0 comments · Fixed by #1490
Assignees

Comments

@smeubank
Copy link
Member

smeubank commented Jul 11, 2022

Problem Statement

Add the source of a transaction name to all events sent with the SDK.
See https://develop.sentry.dev/sdk/event-payloads/transaction/#transaction-annotations

To do:

Integrations where we have to check/add transaction source:

  • asgi (on event, in event processor, has code for saving url style transaction names, but can this only if fastapi is used...)
  • flask (on scope, outside event processor)
  • django (on scope, outside event processor and multiple other places, TODO later: test for "/message/:id" names)
  • bottle (on event, in event processor)
  • falcon (on event, in event processor, TODO: there is no endpoint transaction_style (create ticket for later?))
  • pyramid (on scope, outside event processor)
  • quart (on scope, outside event processor)
  • sanic
  • celery (TODO: update TESTS! rest is done)
  • wsgi (does not set transaction names (or sources) what I think should also be that way in ASGI...)
  • spark (does not have transactions)
  • tornado (on event, in event processor)
  • trytond (does not have transactions)
  • aiohttp (on scope, outside event processor)
  • starlette (needs to use transaction_from_function() to have better endpoint names)
  • aws_lambda (need to check tests in CI because did not run locally because I am too lazy to setup env vars to actual AWS to run tests.)
  • gcp
  • chalice (on scope, outside event processor)

Reference

Develop Spec: Transaction Annotations

getsentry/sentry-javascript#5367

getsentry/sentry-javascript#5345

getsentry/relay#1330

getsentry/develop#624

@smeubank smeubank changed the title (python) Transaction source feat(transcations) Transaction source Jul 11, 2022
@smeubank smeubank linked a pull request Jul 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants