Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transactions): Transaction Source #1490

Merged
merged 48 commits into from
Jul 15, 2022
Merged

feat(transactions): Transaction Source #1490

merged 48 commits into from
Jul 15, 2022

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Jul 11, 2022 •
edited

This adds the transaction_info.source to events. See #1489

@antonpirker antonpirker force-pushed the antonpirker/1489-transaction-source branch from 8b41c2a to 13f8075 Compare July 11, 2022 17:26
@antonpirker
Added tests for transaction name and source in Flask.
b7be7bf
@antonpirker
Renamed function for clarity
7185bfd
@antonpirker
Set transaction source in ASGI.
1fa42c1
@antonpirker
Added tests for transaction name and source in ASGI
cc3a32b
@antonpirker
Added transaction source to bottle
5cf698d
@antonpirker
Improved tests for transaction info for bottle
3b94875
@antonpirker
Refactored tests for transaction info in Flask.
0fcf26e
@antonpirker
Refactored tests for transaction info for ASGI.
c55b991
@antonpirker
Cleanup Flask
d4792fd
@antonpirker
Cleanup ASGI
eac2e8b
@antonpirker
Set transaction source in Django
5232d8a
@antonpirker
Added tests for transaction name and source in Django
a8718b7
@antonpirker
Added source to Transaction class
fbe1bd2
@antonpirker
Added transaction source to Celery
66c5cff
@antonpirker
Quick refactoring
1db75ac
@antonpirker
Added transaction source to Falcon.
fbdf132
@antonpirker
Added tests for transaction source to Falcon
e1e2097
@antonpirker
Added transaction source to Pyramid
9f4b9b6
@antonpirker
Added tests for transaction source to Pyramid.
1125f3e
@antonpirker
Added transaction source to quart.
ff26d8e
@antonpirker
Added tests for transaction source to Quart
a8251cc
@antonpirker
Added transaction source and tests for Sanic
177fc76
@antonpirker
Added transaction source and tests for Tornado.,
4a95775
@antonpirker
Added transaction source and tests for AIOHTTP
57f9c97
@antonpirker
Added transaction source and tests for Chalice
b2165cc
@antonpirker antonpirker force-pushed the antonpirker/1489-transaction-source branch from e4d89fd to 31b880c Compare July 13, 2022 16:14
@antonpirker antonpirker force-pushed the antonpirker/1489-transaction-source branch from 4485c79 to b35dd7b Compare July 13, 2022 17:49
@antonpirker antonpirker self-assigned this Jul 13, 2022
@antonpirker antonpirker force-pushed the antonpirker/1489-transaction-source branch from f9fcef0 to e75666e Compare July 13, 2022 18:55
@antonpirker antonpirker marked this pull request as ready for review July 14, 2022 07:10
sl0thentr0py
sl0thentr0py requested changes Jul 14, 2022
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some stuff to start with

sentry_sdk/utils.py Outdated Show resolved Hide resolved
sentry_sdk/tracing.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/asgi.py Show resolved Hide resolved
sentry_sdk/integrations/asgi.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/bottle.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/django/__init__.py Show resolved Hide resolved
sentry_sdk/integrations/django/__init__.py Show resolved Hide resolved
@smeubank smeubank linked an issue Jul 15, 2022 that may be closed by this pull request
feat(transcations) Transaction source #1489
Closed
18 tasks
sl0thentr0py
sl0thentr0py approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making the changes!
shippit

@antonpirker antonpirker merged commit d4bc0f8 into master Jul 15, 2022
@antonpirker antonpirker deleted the antonpirker/1489-transaction-source branch July 15, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees

@antonpirker antonpirker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(transcations) Transaction source
2 participants
@antonpirker @sl0thentr0py