Skip distributions with incomplete metadata #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rare cases, `importlib.metadata` values may contain `None`, see python/cpython#91216 and python/importlib_metadata#371 The fix skips all distributions with incomplete metadata.
rominf
force-pushed
the
rominf-_generate_installed_modules-metadata-none
branch
from
06f6d87
to
6b73d64
Compare
|
Could you please help me figure out, why this change significantly dropped code coverage, so that I fix it? |
|
Hey @rominf, thank you for this fix. I'll try to find some time next week to check it out. Regarding the coverage I'm not sure, it also reports having increased overall by 1.08%, so I think we're good there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rare cases,
importlib.metadatavalues may containNone, seepython/cpython#91216
and
python/importlib_metadata#371
The fix skips all distributions with incomplete metadata.