Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis Cache Module - 2 - Add Cache Spans #3075

Merged
merged 43 commits into from
May 23, 2024
Merged

Redis Cache Module - 2 - Add Cache Spans #3075

merged 43 commits into from
May 23, 2024

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented May 15, 2024 •
edited

Add new cache spans and add relevant data to it. See specs here: https://develop.sentry.dev/sdk/performance/modules/caches/

This works for all our instrumented redis clients and also in sync and async code.

Part 2/2 for fixing #2965

@antonpirker
x
557165b
@antonpirker
x
5bc00d0
@antonpirker
Some work to use same function for queries and caches module
31c0769
@antonpirker
Moved functions to better place
7a65e5d
@antonpirker
Added tests
7298402
@antonpirker
Fix
d3d485b
@antonpirker
Tests and linting
932fcdc
@antonpirker
Thats important for Python 3.6
3acf6c4
@antonpirker
Fixed some tests
20ae85c
@antonpirker
Removed ipdb
c10585a
@antonpirker
more fixing
9d12889
@antonpirker
Cleanup
bcf3e3e
@antonpirker
Merge branch 'antonpirker/redis-cache-module-1' into antonpirker/redi…
0dfefac 
…s-cache-module-2
@antonpirker
Merge branch 'antonpirker/redis-cache-module-1' into antonpirker/redi…
2a63ac9 
…s-cache-module-2
@antonpirker
Merge branch 'antonpirker/redis-cache-module-1' into antonpirker/redi…
3231674 
…s-cache-module-2
@antonpirker
Async cache spans
20f46f8
@antonpirker
Added async tests
f603fb7
@antonpirker
Fixed async tests
90f92a6
@antonpirker
Guard for not running async tests when there is no async fakeredis fo…
075ae16 
…r that python version
@antonpirker
linting
5ceefb3
@antonpirker antonpirker mentioned this pull request May 17, 2024
Merged
@antonpirker antonpirker changed the title Create cache spans Redis Cache Module - 2 - Add Cache Spans May 17, 2024
@antonpirker antonpirker marked this pull request as ready for review May 17, 2024 13:55
sentrivana
sentrivana approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, see some comments

sentry_sdk/integrations/redis/modules/caches.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/redis/utils.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/redis/utils.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/redis/_sync_common.py Show resolved Hide resolved
antonpirker and others added 17 commits May 22, 2024 13:40
@antonpirker
fix _get_op()
aabda8b
@antonpirker
Cleaning up unused properties/parameters
c5bcd75
@antonpirker
Use _get_safe_key in Django integration
db54981
@antonpirker
Fixed typing
1dded72
@antonpirker
More tests
16aec47
@antonpirker
Only return the keys in set_many, makes more sense
f9eb6ce
@antonpirker
Linting
10d353c
@antonpirker
Cleanup
671763b
@sentrivana
fix(clickhouse): _sentry_span might be missing (#3096)
38c14e9 
We started auto-enabling the ClickHouse integration in 2.0+. This led to it getting auto-enabled also for folks using ClickHouse with Django via `django-clickhouse-backend`, but it turns out that the integration doesn't work properly with `django-clickhouse-backend` and leads to `AttributeError: 'Connection' object has no attribute '_sentry_span'`.
@antonpirker
Make _get_safe_key work for all multi key methods in django and redis
7a0217b
@antonpirker
Fixed kwargs case and updated tests
e1db1f5
@antonpirker
Updated tests
0024f81
@antonpirker
cache.set should be cache.put
7e275eb
@antonpirker
Fix cohere testsuite for new release of cohere. (#3098)
ec23396 
* Check for new class to signal end of stream
@antonpirker
Merge branch 'master' into antonpirker/django-caching-module
941ca77
@antonpirker
Merge branch 'antonpirker/django-caching-module' into antonpirker/red…
80f50d5 
…is-cache-module-1
@antonpirker
Merge branch 'antonpirker/redis-cache-module-1' into antonpirker/redi…
24d96f9 
…s-cache-module-2
@antonpirker antonpirker merged commit 8c33a76 into antonpirker/redis-cache-module-1 May 23, 2024
108 checks passed
@antonpirker antonpirker deleted the antonpirker/redis-cache-module-2 branch May 23, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antonpirker @sentrivana