Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add feature for using surf with the h1-client and rustls #404

Closed
wants to merge 1 commit into from
Closed

feat: add feature for using surf with the h1-client and rustls #404

wants to merge 1 commit into from

Conversation

misuzu
Copy link

@misuzu misuzu commented Jan 12, 2022

This feature enables usage of surf http backend with rustls.

flub
flub suggested changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum, seems like CI says this isn't so simple. Could you fix this?

@flub
Copy link
Contributor

flub commented Jan 13, 2022

could be because of --all-features use by CI, so this may need more CI tweaks to make this work.

@misuzu misuzu mentioned this pull request Jan 13, 2022
Merged
@MarijnS95
Copy link
Contributor

It should now be possible to add this directly under the rustls feature when #454 lands 🎉

@misuzu misuzu closed this Oct 21, 2022
@MarijnS95
Copy link
Contributor

@misuzu I meant for you to rebase and add it in this PR, as I did not enable the feature in #454 😉

@misuzu
Copy link
Author

misuzu commented Oct 21, 2022

@misuzu I meant for you to rebase and add it in this PR, as I did not enable the feature in #454 wink

AFAIU surf is still needs to be updated and there was no releases since last year. I'll submit new pull-request after next release of surf.

@MarijnS95
Copy link
Contributor

Feel free to just reuse PRs, makes it easier on the deep-linking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flub flub flub requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@misuzu @flub @MarijnS95