Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add initial values for functions to the data #445

Merged
merged 2 commits into from May 20, 2022
Merged

add initial values for functions to the data #445

merged 2 commits into from May 20, 2022

Conversation

jessfraz
Copy link
Contributor

this fixes #440

spans later in the functions were working and showing up in the UI but not the original set of values passed to the function.

@jessfraz
add tags
ddcbd07 
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Swatinem
Swatinem approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, that sure was a big oversight, thanks for fixing this up!

A test for this might be nice. I think we do have tests for manual record, etc.

@jessfraz
Copy link
Contributor Author

will add some tests!

@Swatinem Swatinem enabled auto-merge (squash) May 20, 2022 09:09
@Swatinem Swatinem merged commit 25806c7 into getsentry:master May 20, 2022
@DmitrySamoylov
Copy link
Contributor

@jessfraz thanks for the PR! Were you able to see the fields from #[instrument] somewhere at the event page? I still only see fields that I pass directly to error! macro.

@jessfraz
Copy link
Contributor Author

jessfraz commented Jul 1, 2022 •
edited

I don't see them on the event page but I know they exist since I tend to see them logged! As in in my console

@jessfraz jessfraz deleted the set-tags2 branch July 1, 2022 16:27
@DmitrySamoylov
Copy link
Contributor

But those are logged to console via tracing_subscriber::fmt::layer(), it doesn't have to do with Sentry, right? 🤔

@jessfraz
Copy link
Contributor Author

jessfraz commented Jul 1, 2022

yes for sure i was thinking its more a sentry UI issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tracing: added fields don't show up in Sentry
3 participants
@jessfraz @DmitrySamoylov @Swatinem