feat(contexts): Report macOS version instead of Darwin kernel version #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajivshah3
commented
Mar 25, 2022
Swatinem
approved these changes
Mar 28, 2022
|
While you are at it, feel free to add this change to the CHANGELOG.md |
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
==========================================
- Coverage 80.15% 80.11% -0.05%
==========================================
Files 73 73
Lines 8355 8361 +6
==========================================
+ Hits 6697 6698 +1
- Misses 1658 1663 +5 |
Swatinem
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with the other Sentry SDKs, the Rust SDK should report the macOS name ("macOS" instead of "Darwin"), version, and build. This PR uses the approach from
sentry-nativeby callingsysctlbynamewithkern.osproductversionandkern.osversion.Closes #449