Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(anyhow): Extract public event_from_error fn #476

Merged
merged 2 commits into from Jun 23, 2022
Merged

ref(anyhow): Extract public event_from_error fn #476

merged 2 commits into from Jun 23, 2022

Conversation

kamilogorek
Copy link
Contributor

Note that currently first test is not running.

Resolves #467

@kamilogorek kamilogorek requested a review from a team June 23, 2022 13:14
Swatinem
Swatinem approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think it matters too much to test the case without the backtrace feature ;-)

@kamilogorek kamilogorek enabled auto-merge (squash) June 23, 2022 13:24
@kamilogorek
Copy link
Contributor Author

Removed it then.

@kamilogorek kamilogorek merged commit 0112a4e into master Jun 23, 2022
@kamilogorek kamilogorek deleted the anyhow-event-from-error branch June 23, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support event_from_error for anyhow integration
2 participants
@kamilogorek @Swatinem