feat(transport): Add option to disable SSL verification #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding this option will allow to use self-signed certificates in the user's self-hosted environments. Using this option also allows to use any types of certs, even experired which can introduce vulnerabilities, since all the certificates are trusted by default. That's why we must make clear that it's a last resort if there is no possibility to use legitimate certificate (e.g. Let's Encrypt or similar).
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #508 +/- ##
==========================================
- Coverage 79.15% 78.63% -0.52%
==========================================
Files 76 76
Lines 9086 9157 +71
==========================================
+ Hits 7192 7201 +9
- Misses 1894 1956 +62 |
Swatinem
approved these changes
Oct 17, 2022
sentry/src/transports/surf.rs
Outdated
| let client = if let Some(client) = client { | ||
| client | ||
| } else { | ||
| let mut http_client = http_client::isahc::IsahcClient::new(); |
There was a problem hiding this comment.
if/else might be better here I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this option will allow to use self-signed certificates in the user's self-hosted environments.
Using this option also allows to use any types of certs, even expired which can introduce vulnerabilities, since all the certificates are trusted by default. That's why we must make clear that it's a last resort if there is no possibility to use legitimate certificate (e.g. Let's Encrypt or similar).
related getsentry/relay#1499