Add default TlsConnector for ureq when native-tls is enabled #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Apr 6, 2023
Comment on lines
+57
to
59
| if options.accept_invalid_certs { | ||
| #[cfg(feature = "rustls")] | ||
| { |
There was a problem hiding this comment.
Lets see if the compiler will complain about this if being empty when the feature is not enabled.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #564 +/- ##
==========================================
- Coverage 70.51% 70.50% -0.02%
==========================================
Files 66 66
Lines 6679 6680 +1
==========================================
Hits 4710 4710
- Misses 1969 1970 +1 |
|
I opened up #565 to fix the clippy errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #563