tower: Use tx.set_request() to set HTTP request metadata
#571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this the transaction does not have any HTTP request metadata attached, because apparently the event processor is not running for performance traces. Note that I had to reorder the contents of the `configure_scope()` callback to be able to access `sentry_req` before it disappears into the `add_event_processor()` callback.
Turbo87
force-pushed
the
tower-transaction-request
branch
from
bfc54c6
to
3aeb946
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #571 +/- ##
==========================================
- Coverage 70.58% 70.57% -0.02%
==========================================
Files 66 66
Lines 6704 6705 +1
==========================================
Hits 4732 4732
- Misses 1972 1973 +1 |
Swatinem
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this the transaction does not have any HTTP request metadata attached, because apparently the event processor is not running for performance traces. After this patch the performance trace looks like this:
Note that I had to reorder the contents of the
configure_scope()callback to be able to accesssentry_reqbefore it disappears into theadd_event_processor()callback.This should address #439 (review)
/cc @Swatinem