Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry: Add tower-axum-matched-path feature #572

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Apr 25, 2023

#570 introduced the corresponding feature on the sentry-tower crate, but it isn't really useable directly from the sentry crates, which I assume is the recommended way of using these integration crates?

This PR introduces a tower-axum-matched-path feature on the top-level sentry crate to fix this. I'm not a huge fan of the long feature name, but I couldn't think of anything more suitable 馃槄

/cc @Swatinem

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well yes, in hindsight, splitting out every integration from the main crate might not have been the best decision :-D

@Swatinem Swatinem merged commit 63c280d into getsentry:master Apr 25, 2023
12 checks passed
@Turbo87 Turbo87 deleted the axum branch April 25, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants