ref(profiling): do not set the profile_id in the profile context on the transaction. #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better to leave Relay set it. This will ensure the profile is correctly accepted and validated before we set it instead of having to remove the profile id from the context in case the profile is rate limited/invalid or else.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #573 +/- ##
==========================================
+ Coverage 70.57% 70.65% +0.08%
==========================================
Files 66 66
Lines 6705 6697 -8
==========================================
Hits 4732 4732
+ Misses 1973 1965 -8 |
Swatinem
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better to leave Relay set it.
This will ensure the profile is correctly accepted and validated before we set it instead of having to remove the profile id from the context in case the profile is rate limited/invalid or else.