Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for axum 0.7.1 #627

Merged

Conversation

benjaminjellis
Copy link
Contributor

Hi,

I'm not sure if you accept contributions so feel free to close this if not.

Axum recently update to 0.7.0 which doesn't compile using sentry 0.31.8, as it turns out this is simple to fix by bumping the http dependency in sentry-tower to 1.0.0 to match that in axum.

@TimDiekmann
Copy link

TimDiekmann commented Nov 28, 2023

I was about to open the exact same PR 😄.
I tested bumping http to 1.0 in sentry-tower locally and it seems to work. However, sentry uses a bunch of dev-dependencies, which still indirectly rely on the old 0.2.9 version of http and I think this is why the changes to Cargo.lock includes old versions.

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m a bit surprised this is the only thing that needs bumping, I thought there was more in the tower ecosystem that had version bumps due to hyper.

@Swatinem Swatinem enabled auto-merge (squash) November 28, 2023 08:21
@Swatinem Swatinem merged commit 6f1ac71 into getsentry:master Nov 28, 2023
13 checks passed
@TimDiekmann
Copy link

I don't know the typical release flow for sentry, is it just the release workflow dispatch? If so, would it be possible to trigger it?

@indietyp
Copy link

Also it appears like http 0.2 is still in the dependency tree, axum and actix seem to need updating as well. 🤔

@Swatinem
Copy link
Member

I did a ton more dependency updates in #628

jan-auer added a commit that referenced this pull request Dec 11, 2023
* master:
  tracing: send spans' attributes along with the event ones (#629)
  release: 0.32.0
  Update crate dependencies (#628)
  feat: bump http to 1.0.0 (#627)
  release: 0.31.8
  MonitorSchedule constructor that validates crontab syntax (#625)
  fix(docs): Fix some doc errors that slipped in (#623)
  docs(tower): Mention how to enable http feature from sentry crate (#622)
  build(deps): bump rustix from 0.37.23 to 0.37.25 (#619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants