Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@sentry/cli] Path resolution to @sentry/cli is unreliable #208

Closed
2 tasks
lobsterkatie opened this issue Nov 7, 2022 · 4 comments · Fixed by #211
Closed
2 tasks

[@sentry/cli] Path resolution to @sentry/cli is unreliable #208

lobsterkatie opened this issue Nov 7, 2022 · 4 comments · Fixed by #211

Comments

@lobsterkatie
Copy link
Member

As reported by Cramer, following our stock nextjs SDK instructions to use the wizard through npx led to @sentry/cli being resolved to ../../.npm/_npx/a8388072043b4cbc/node_modules/@sentry/cli/bin/sentry-cli rather than the copy installed in the project's node_modules folder. (This then gets inserted in the sentry.properties file the wizard generates.)

  • Figure out why this is happening
  • Perhaps first decide if we even need to include the path to the executable in sentry.properties when dealing with @sentry/cli. It should download the binary to a standard place, so we might not need this at all.
@smeubank
Copy link
Member

smeubank commented Nov 8, 2022

@kamilogorek this something you might have an idea about off the top of your head?

@lobsterkatie
Copy link
Member Author

Related: getsentry/sentry-cli#915

@lobsterkatie
Copy link
Member Author

Per @kamilogorek in slack:

fwiw npx doesnt install its traasnsitive dependencies locally, so as long as someone has NODE_PATH set to follow their volta/yarn/npm/whatever node_modules, it will never work, due to @sentry/cli being installed inside .npx directory

@sentry/cli should be installed as a dependency of @sentry/nextjs. We’re working on making it not a dependency of the wizard: #201.

@vladanpaunovic
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants