Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Always check for both, nextjs and sdk version #209

Merged
merged 1 commit into from
Nov 9, 2022
Merged

fix: Always check for both, nextjs and sdk version #209

merged 1 commit into from
Nov 9, 2022

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Nov 9, 2022 •
edited

Prior to that change, @sentry/nextjs check was never called if next was there, as true || fn() will not call fn.

@timfish
Copy link
Collaborator

timfish commented Nov 9, 2022 •
edited

I don't think this PR fixes the linked issue since #208 seems to be caused by require.resolve when the wizard is called by npx.

The CLI path is wrong in Remix projects too.

@kamilogorek
Copy link
Contributor Author

Right, had few tabs opened and linked it here by accident.

@kamilogorek kamilogorek merged commit b79a3f4 into master Nov 9, 2022
@kamilogorek kamilogorek deleted the update-deps-assertions branch November 9, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lobsterkatie lobsterkatie Awaiting requested review from lobsterkatie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamilogorek @timfish @AbhiPrasad