Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(jest): Upgrade jest to 24.8.0 #14311

Closed
wants to merge 4 commits into from

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Aug 7, 2019

@billyvg billyvg requested a review from a team August 7, 2019 21:46
Copy link
Member

@evanpurkhiser evanpurkhiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any significant changes?

@billyvg
Copy link
Member Author

billyvg commented Aug 7, 2019

Didn't see any, but something definitely changed with module resolution -- had to change some things w/ moment-timezone

@billyvg
Copy link
Member Author

billyvg commented Aug 7, 2019

Sigh, this warning keeps getting thrown:

This problem is likely caused by another plugin injecting
"_default" without registering it in the scope tracker. If you are the author
 of that plugin, please use "scope.registerDeclaration(declarationPath)".
The exported identifier "_default" is not declared in Babel's scope tracker
as a JavaScript value binding, and "@babel/plugin-transform-typescript"
never encountered it as a TypeScript type declaration.
It will be treated as a JavaScript value.

@billyvg
Copy link
Member Author

billyvg commented Aug 9, 2019

Warnings might be due to babel/babel#10264 which is fixed in babel/babel#10302

@billyvg billyvg force-pushed the build/jest/upgrade-jest-24.8.0 branch from 607af56 to 57ba2e1 Compare August 22, 2019 21:28
@billyvg billyvg added the Do Not Merge Don't merge label Oct 2, 2019
@billyvg
Copy link
Member Author

billyvg commented Nov 12, 2019

Closing in favor of #15533

@billyvg billyvg closed this Nov 12, 2019
@billyvg billyvg deleted the build/jest/upgrade-jest-24.8.0 branch November 12, 2019 23:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Do Not Merge Don't merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants