Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): Split frontend tests into 2 instances #25359

Merged
merged 5 commits into from Apr 19, 2021

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Apr 16, 2021

Frontend test duration has been creeping up and failing. There are some optimizations we could do, but I think this needs to be split for now.

Took the logic from this post jestjs/jest#6270 (comment) and applied it here.

Frontend test duration has been creeping up and failing. There are some optimizations we could do, but I think this needs to be split for now.
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2021

size-limit report

Path Base Size (4d8cc60) Current Size Change
public/app.js 321.59 KB 321.61 KB +0.01% 🔺
public/vendor.js 583.41 KB 583.41 KB 0%
public/sentry.css 23.82 KB 23.82 KB 0%

Copy link
Member

@evanpurkhiser evanpurkhiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@billyvg
Copy link
Member Author

billyvg commented Apr 19, 2021

Merging this because splitting frontend tests causes the check name to change and not meet the branch protection requirements, but they are passing under frontend tests (0) and frontend tests (1)

@billyvg billyvg enabled auto-merge (squash) April 19, 2021 16:24
@billyvg billyvg disabled auto-merge April 19, 2021 16:25
@billyvg billyvg merged commit 550c9d4 into master Apr 19, 2021
@billyvg billyvg deleted the build/ci/split-frontend-tests branch April 19, 2021 16:25
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants