feat(ci): Balance frontend tests #30949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
changed the title
size-limit report
|
billyvg
force-pushed
the
feat/ci/jest-reporter-for-test-times
branch
from
b4a059e
to
b045362
Compare
| } | ||
| } | ||
|
|
||
| module.exports = TestBalancer; |
There was a problem hiding this comment.
Can you write this in typescript as well?
There was a problem hiding this comment.
Not possible unfortunately: jestjs/jest#8810
|
Here's an example of frontend tests have wildly differing test sharding: frontend (0) taking 23 minutes |
|
I think this is useful enough to merge as-is - ideally we would add some automation to update the balance JSON file. But I think even without automating it, this should suffice for awhile (until we add new tests that are quite slow). Some automation ideas:
|
evanpurkhiser
approved these changes
Jan 6, 2022
|
Not sure what's up with the jest snapshots, but the tests are definitely getting run: |
priscilawebdev
approved these changes
Jan 7, 2022
|
|
||
| mountGlobalModal(); | ||
| screen.getByTestId('widget-add').click(); |
There was a problem hiding this comment.
should this be userEvent.click(screen.getByTestId('widget-add')) ?
|
|
||
| mountGlobalModal(); | ||
| screen.getByTestId('widget-add').click(); | ||
|
|
||
| // Add a custom widget to the dashboard | ||
| (await screen.findByText('Custom Widget')).click(); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a jest reporter to record the test durations of our frontend tests. It also changes our runner to look for a results JSON and attempt to balance tests between our CI runners.