chore(ppf): Stop sending group states from the post process forwarder #69469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
wedamija
force-pushed
the
danf/cleanup-post-process
branch
from
efb8775
to
a0b578a
Compare
wedamija
force-pushed
the
danf/ppf-stop-sending-group-states
branch
from
6d604ad
to
11a122a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #69469 +/- ##
=======================================
Coverage 79.64% 79.65%
=======================================
Files 6479 6479
Lines 287636 287617 -19
Branches 49567 49564 -3
=======================================
Hits 229089 229089
+ Misses 58110 58091 -19
Partials 437 437
|
wedamija
force-pushed
the
danf/cleanup-post-process
branch
from
a0b578a
to
a3ce302
Compare
We stop relying on `group_states` in #63130. Once this has merged and is in production, we can stop sending `group_states` entirely via the ppf. We can stop including the `group_states` info in the Kafka messages in a later pr
wedamija
force-pushed
the
danf/ppf-stop-sending-group-states
branch
from
11a122a
to
7a22436
Compare
snigdhas
approved these changes
Apr 23, 2024
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We stop relying on
group_statesin #63130. Once this has merged and is in production, we can stop sendinggroup_statesentirely via the ppf.We can stop including the
group_statesinfo in the Kafka messages in a later pr