feat: support electron V5

[magne4000]

Diff description

• Upgraded Electron, Process Manager and Mocha dependencies
• Changed calls for schema registration (https://github.com/electron/electron/blob/master/docs/api/breaking-changes.md#privileged-schemes-registration)
• Changed call for isolated worlds (https://github.com/electron/electron/blob/master/docs/api/breaking-changes.md#webframe-isolated-world-apis)
• Changed playground browser window options web preferences (https://github.com/electron/electron/blob/master/docs/api/breaking-changes.md#new-browserwindow-webpreferences-)
• Reverted schema protocol handler on hostname binding
• Added a workaround for the missing window.opener reference with native window open (window.opener opened from webview is null after cross site navigation electron/electron#18032)

[hugomano]

Origin chrome-extension is now a secure origin in the renderer

[hugomano]

Blocked by electron/electron#17989 (workaround for electron/electron#18032).

Tried to hook with an event listener like this:

const hookWindowOpen = (webContents) => {
  webContents.on('new-window', (event, url, frameName, disposition, options, additionalFeatures) => {
    event.preventDefault()

    Object.assign(options, {
      show: false,
      width: 600,
      height: 800,
      webPreferences: {
        nodeIntegration: true,
        contextIsolation: false,
        preload: path.join(__dirname, '../renderer/init.js')
      }
    })

    console.log(options);

    const win = new BrowserWindow(options);

    win.once('ready-to-show', () => {
      win.show()
      console.log(url)
      win.webContents.loadURL('https://github.com')
    })

    event.newGuest = win;
  })
}

app.on('web-contents-created', function (event, webContents) {
  hookWindowOpen(webContents)
})

the window.opener stay null after navigation and preloads doesn't load. Really related to the process model IMO.

[hugomano]

Test with BrowserWindow

Try with the main browser window instead of the webview

function createWindow() {
  mainWindow = new BrowserWindow({
    width: 800,
    height: 600,
    webPreferences: {
      nodeIntegration: true,
      webviewTag: true,
      contextIsolation: false,
      nativeWindowOpen: true,
    }
  });

  mainWindow.loadURL('https://mail.google.com');
}
...

It's the same behavior than our webview:

• window.open('https://mail.google.com'), opener available but not preloads
• window.open('https://github.com'), opener not accessible and preloads loaded

Don't attach the newly created window for newGuest on new-open

mainWindow.webContents.on('new-window', (event, url, frameName, disposition, options, additionalFeatures) => {
    ...
})

The options include the embedder through options.webContents which is the reference for window.opener.

In all case, if we create an orphan browser window, the opener is null and preloads are loaded.

Navigation

setup: the opener is webview with domain mail.google.com

• catch the new-open event for loading mail.google.com: the opener is available but preloads are missing
• catch the new-open event for loading github.com: the opener is null but preloads are loaded
• catch the new-open event for loading mail.google.com then navigate to GitHub.com then back to mail.google.com: the opener is null and preloads are loaded

[alexstrat]

After the fix of electron/electron#18032 in electron 5.0.4, I think we can remove most of these workarounds, no?

[hugomano]

yep I on it

[alexstrat]

🆙