-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for outdated python and gevent versions #192
Conversation
ca99152
to
b2da74f
Compare
Ooh, that was a very quick merge :) Can I ask for a few more things: the pure formatting changes to be added to a git-blame ignore file, like this: https://github.com/locustio/locust/blob/master/.git-blame-ignore-revs Did you run pyupgrade? If not, try it and see what changes it suggests. |
Do you really want |
So far I was using About About the ignore-refs, yeah, in hindsight it was quite stupid to do a squash commit with all that changes together :/ Are you fine with putting the whole squashed commit hash into the ignore list? Otherwise, I guess we need to redo the whole merge. |
Regarding blame, I didnt see that you squashed as well. Never mind then, definitely not worth redoing anything for that. I've found ruff very stable. Can you add it to tox? Ideally as a separate env (like here https://github.com/locustio/locust/blob/a7ca357ca15e10bc77b4bc3b0dd96548c84f7d9f/tox.ini#L34) but because it is so fast we could just run it for every python version (if that is easier for you to do). Adding a pre-commit hook would be even nicer, but that can be step 2. |
@cyberw please have a look. Should be good for now.