Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current URL implementation did quite some parsing, which is nowadays already done in a more robust and clean way in the standard library. This PR preserves the previous URL interface, while leaving all the actual work to
urllib.parse.urlparse
andurllib.parse.ParseResult
.It would be debatable, if we shouldn't drop the url module entirely and just use
urllib.parse
and all tools within directly without any wrapping. Mb something to keep in mind for a potential future major version bump.