Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add presented_time to Drawable #300

Closed
wants to merge 0 commits into from
Closed

add presented_time to Drawable #300

wants to merge 0 commits into from

Conversation

marcpabst
Copy link

@marcpabst marcpabst commented Dec 31, 2023 •
edited

@MarijnS95
Copy link

Good to mention that this PR depends on #298, which should be (squash-)merged first.

@marcpabst
Copy link
Author

Yep - sorry! Never submitted a PR that supersedes another one and was under the impression that GitHub keeps track of that automatically.

@MarijnS95
Copy link

MarijnS95 commented Jan 4, 2024 •
edited

@marcpabst no worries! GitHub doesn't have any support for this at all, so a little hint in the PR description for maintainers is the least one can do (there's a finicky trick with target branches but it doesn't work across forks and is super fragile).

Note also that you don't need to create a PR on your local fork to incorporate another change as a base - pro-tip for next time 👍

@grovesNL grovesNL closed this May 23, 2024
@grovesNL
Copy link
Collaborator

Just rebasing this, will merge in a minute

@grovesNL grovesNL mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcpabst @MarijnS95 @grovesNL