Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error improvements in WGSL-in and SPV-in #810

Merged
merged 2 commits into from May 3, 2021
Merged

Error improvements in WGSL-in and SPV-in #810

merged 2 commits into from May 3, 2021

Conversation

kvark
Copy link
Member

@kvark kvark commented May 2, 2021

SPV-in's error didn't derive Error and wasn't even publicly exposed.
WGSL's error had a lifetime, which makes it unable to form error chains, see dtolnay/thiserror#68
This PR is largely made to address gfx-rs/wgpu#1359

@kvark kvark requested a review from grovesNL May 2, 2021 04:51
grovesNL
grovesNL approved these changes May 3, 2021
View reviewed changes
Copy link
Collaborator

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing source again in the public API feels a little strange because the spans we stored depend on the source remaining the same. e.g. technically the spans could be pointing to invalid offsets if a different source is provided

@kvark kvark merged commit 46a244f into gfx-rs:master May 3, 2021
@kvark kvark deleted the error branch May 3, 2021 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grovesNL grovesNL grovesNL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kvark @grovesNL