Fix Subgroup Ops on VK 1.2 Device #5624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
commented
Apr 29, 2024
cwfitzgerald
added
the
PR: needs back-porting
cwfitzgerald
force-pushed
the
fix-mvk-subgroups
branch
from
0c40848
to
0a79002
Compare
teoxoy
reviewed
May 14, 2024
teoxoy
approved these changes
May 14, 2024
EriKWDev
pushed a commit
to bitwise-git/wgpu
that referenced
this pull request
May 14, 2024
Wumpf
pushed a commit
to Wumpf/wgpu
that referenced
this pull request
May 18, 2024
ErichDonGubler
pushed a commit
that referenced
this pull request
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #5551
Description
Our subgroup code assumed that if the physical device supported it, we would enable the extension. However the extension enablement code checked if the user actually asked for subgroup ops.