New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hal] Document resource destruction methods, and a few other things. #5627
[hal] Document resource destruction methods, and a few other things. #5627
Conversation
ca58eee
to
daa3653
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, minus nits I'm trusting to be handled.
f3ac026
to
bf6cce0
Compare
@ErichDonGubler I've accepted most of your suggestions, but had some questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with nits
that didn't go well |
e58e2d7
to
7080697
Compare
Okay, I think I've undone the damage. |
7080697
to
5ce674b
Compare
Document some more safety expectations for - resource destruction methods - `CommandEncoder` methods - `Queue::submit` Document `Fence` creation a bit. Document the `Queue` trait a bit. Document `vulkan` shader module handling a bit.
5ce674b
to
c92968e
Compare
Document some more safety expectations for
CommandEncoder
methodsQueue::submit
Document
Fence
creation a bit.Document the
Queue
trait a bit.